🔧 ⬆️ 🚸 Upgrade android to API 33 #1019
Merged
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support building individual platforms with the prod JS but dev native code
- This will allow us to test the prod JS by connecting with a debugger (if needed)
- Also allows quicker dev cycle by building only one platform at a time
(note that for testing outside the devapp, we need to build the app every time)
- Ensures that we don't need to get off the VPN just to build iOS
- Ensures that we can build prod JS iOS version for archival and submission
- Support building android with the prod JS and prod native code
- To support building the aab to upload to the play store
Testing done:
- Used for building the NREL OpenPATH app
So that we use webpack for the javascript properly Testing done: - Used to build the NREL OpenPATH app
So that we can archive it to check out old functionality if needed
- `cordova-android` to 12 - `cordova-plugin-file` to 8.0.0 - Remove SDK version overrides and go with the cordova-android defaults Note that this will not work until e-mission/e-mission-data-collection#207 is merged #1016 (comment)
Everything should compile now. We can check in the sdk changes independently; the main goal is to start testing these changes before the release.
🔧 ⬆️ 🚸 Upgrade android to API 33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Upgrade android to API 33
🔧 build script updates
🚸 permission usability updates
Merging over from #1016