Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile changes to unblock routing #1029

Merged

Commits on Sep 11, 2023

  1. convert the log page to React

    for react routing, we need to convert this page and the sync settings page
    
    maintain access for now by routing to a React page with angular routing
    
    using AlertBars for the error messages
    
    first draft: scrolling the FlashList is broken and the data doesn't load unless you manually tap refresh
    Abby Wheelis committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c240f79 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Merge remote-tracking branch 'upstream/label_dashboard_profile_sept_2…

    …023' into unblock-routing
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ef6ba26 View commit details
    Browse the repository at this point in the history
  2. refactor dialogStyle and create Action Menu

    instead of making dialogStyle a parameter, export and import the stylesheet where it is used, to maintain consistency and limit parameters
    
    Needed something similar to some of the dialogs in ProfileSettings for the SyncLogs -- so create a component `ActionMenu` to show the list of options, replacing the two hard-coded modals (carbon and force state) with an instance of ActionMenu
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c8ceafe View commit details
    Browse the repository at this point in the history
  3. ActionMenu title

    so each has it's own title, add a title parameter
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b682e53 View commit details
    Browse the repository at this point in the history
  4. add SensedPage, fix scrolling

    the other page that needs conversion is the one that shows sensed data, so convert it as well
    
    Resolved scroll issue by getting out of Angular -- using a full screen modal helps us accomplish this
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7e55e83 View commit details
    Browse the repository at this point in the history
  5. take out old code

    we no longer rely on any of the angular code that controlled the log pages, so we can remove the files and the places they were imported
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4c430d2 View commit details
    Browse the repository at this point in the history
  6. update log page to load more

    previously, was not loading more when you hit the end of the list, now the list loads more when you reach the end
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f1f9b57 View commit details
    Browse the repository at this point in the history
  7. load on enter

    load the log pages when their visibility changes, this seems cleaner than tying it to the config, since this is unrelated to the config
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e21cb6e View commit details
    Browse the repository at this point in the history
  8. refactor .then() to try/catch

    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    496b353 View commit details
    Browse the repository at this point in the history
  9. resolve error

    I was getting a mysterious "unrecognized selector" error and came to the conclusion that it was because loadStats.currentStart was null on first load, by setting a fallback, the error is resolved
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fe44ae6 View commit details
    Browse the repository at this point in the history
  10. remove infiniteScrollComplete broadcasts

    these had been commented out, and by searching the codebase I came to the conclusion that they were for communicating with angular/ionic, which we no longer use
    
    unlike other broadcasts, this is not received by other parts of our code, to trigger some action, so we don't need it
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e50f0a1 View commit details
    Browse the repository at this point in the history
  11. fix sensed formatting

    I was using react-native Text when I wanted react-native-paper Text
    Abby Wheelis committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fd32aee View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. i18n for ui strings

    Adding translations for the user-visible strings to ensure users can access the dev zone, the logs will be in English, but with headers and error messages in selected language participating in debugging will be easier
    Abby Wheelis committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d20bf2e View commit details
    Browse the repository at this point in the history
  2. remove old functions

    we don't need these show sensed or show logs anymore!
    Abby Wheelis committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f132056 View commit details
    Browse the repository at this point in the history
  3. factor out "Locations" and "Motion Type"

    these two options are not supported, so we should not present them to the user -- removing them leaves us with one option, so no need for an options menu
    
    This reduces the complexity of the sensed data page significantly
    
    note about removing options: e-mission#1029 (comment)
    Abby Wheelis committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    723c5e7 View commit details
    Browse the repository at this point in the history
  4. combine dev-errors into errors

    Abby Wheelis committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d04d5ee View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. React Control Helpers

    create a React version of ControlCollectionHelper and ControlSync Helper. These hold the logic for interfacing with the plugins, as well as UI elements for editing menus and various alerts / messages
    
    The place this is being stored has also changed, we no longer need to import from the other repos
    
    These helpers will eliminate the last parts of React routing, and allow us to no longer rely on the broadcast of "control update complete" to ensure the UI stays up to date
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5e7a50c View commit details
    Browse the repository at this point in the history
  2. fix medium accuracy

    medium accuracy switch was broken, now can be toggled smoothly
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9255675 View commit details
    Browse the repository at this point in the history
  3. remove update complete listeners

    no longer needed, as refreshCollect settings is called after toggling accuracy, toggling tracking, and when the settings editor is closed
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1b8a43c View commit details
    Browse the repository at this point in the history
  4. eliminate settingsScope

    no longer rely on settingsScope to catch recomputeAppStatus, because we check on resume, this is not needed
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9078488 View commit details
    Browse the repository at this point in the history
  5. remove "safeToggle"

    the debouncing patch for toggleLowAccuracy is no longer needed!
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e02db4a View commit details
    Browse the repository at this point in the history
  6. prevent "missing argument errors"

    since these arguments are optional, and we render based on their existence, set the default to undefined
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d55760f View commit details
    Browse the repository at this point in the history
  7. remove safe toggle code

    no longer need to debounce, so no need to keep code around
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2cb1145 View commit details
    Browse the repository at this point in the history
  8. isolate forceSync code to ControlSyncHelper

    to start decluttering `ProfileSettings` move the component to the ControlSyncHelper then import it into `Profile Settings` by exporting a component, we can wrap the popups and their states into one place
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1189700 View commit details
    Browse the repository at this point in the history
  9. don't store a duplicate copy of the collectConfig

    this was one way I attempted to control the ControlSettings, but moved to set/get from a central location (plugin) for one-off changes (toggles) and using the local config, and saving once, when editing with the settings editor modal
    Abby Wheelis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    df78758 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. move functions into helpers

    moving endForceSync and forceTransition into their respective helpers
    Abby Wheelis committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    1551eee View commit details
    Browse the repository at this point in the history
  2. restore log statement

    Abby Wheelis committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    1cfb190 View commit details
    Browse the repository at this point in the history
  3. fetch DB before updating

    Abby Wheelis committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f012973 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. move sync rows to devZone

    Abby Wheelis committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    c46e2dc View commit details
    Browse the repository at this point in the history
  2. move from .then to await

    for consistency and readability, re-writing the forceSync to rely on await rather than chained .then statements
    Abby Wheelis committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    7f8ff42 View commit details
    Browse the repository at this point in the history
  3. endTripForceSync using await

    for readability, switch from chained .then statements to using await calls
    Abby Wheelis committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    2876872 View commit details
    Browse the repository at this point in the history