-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile changes to unblock routing #1029
Profile changes to unblock routing #1029
Commits on Sep 11, 2023
-
for react routing, we need to convert this page and the sync settings page maintain access for now by routing to a React page with angular routing using AlertBars for the error messages first draft: scrolling the FlashList is broken and the data doesn't load unless you manually tap refresh
Abby Wheelis committedSep 11, 2023 Configuration menu - View commit details
-
Copy full SHA for c240f79 - Browse repository at this point
Copy the full SHA c240f79View commit details
Commits on Sep 12, 2023
-
Merge remote-tracking branch 'upstream/label_dashboard_profile_sept_2…
…023' into unblock-routing
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for ef6ba26 - Browse repository at this point
Copy the full SHA ef6ba26View commit details -
refactor dialogStyle and create Action Menu
instead of making dialogStyle a parameter, export and import the stylesheet where it is used, to maintain consistency and limit parameters Needed something similar to some of the dialogs in ProfileSettings for the SyncLogs -- so create a component `ActionMenu` to show the list of options, replacing the two hard-coded modals (carbon and force state) with an instance of ActionMenu
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for c8ceafe - Browse repository at this point
Copy the full SHA c8ceafeView commit details -
so each has it's own title, add a title parameter
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for b682e53 - Browse repository at this point
Copy the full SHA b682e53View commit details -
the other page that needs conversion is the one that shows sensed data, so convert it as well Resolved scroll issue by getting out of Angular -- using a full screen modal helps us accomplish this
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 7e55e83 - Browse repository at this point
Copy the full SHA 7e55e83View commit details -
we no longer rely on any of the angular code that controlled the log pages, so we can remove the files and the places they were imported
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 4c430d2 - Browse repository at this point
Copy the full SHA 4c430d2View commit details -
previously, was not loading more when you hit the end of the list, now the list loads more when you reach the end
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for f1f9b57 - Browse repository at this point
Copy the full SHA f1f9b57View commit details -
load the log pages when their visibility changes, this seems cleaner than tying it to the config, since this is unrelated to the config
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for e21cb6e - Browse repository at this point
Copy the full SHA e21cb6eView commit details -
Abby Wheelis committed
Sep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 496b353 - Browse repository at this point
Copy the full SHA 496b353View commit details -
I was getting a mysterious "unrecognized selector" error and came to the conclusion that it was because loadStats.currentStart was null on first load, by setting a fallback, the error is resolved
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for fe44ae6 - Browse repository at this point
Copy the full SHA fe44ae6View commit details -
remove infiniteScrollComplete broadcasts
these had been commented out, and by searching the codebase I came to the conclusion that they were for communicating with angular/ionic, which we no longer use unlike other broadcasts, this is not received by other parts of our code, to trigger some action, so we don't need it
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for e50f0a1 - Browse repository at this point
Copy the full SHA e50f0a1View commit details -
I was using react-native Text when I wanted react-native-paper Text
Abby Wheelis committedSep 12, 2023 Configuration menu - View commit details
-
Copy full SHA for fd32aee - Browse repository at this point
Copy the full SHA fd32aeeView commit details
Commits on Sep 13, 2023
-
Adding translations for the user-visible strings to ensure users can access the dev zone, the logs will be in English, but with headers and error messages in selected language participating in debugging will be easier
Abby Wheelis committedSep 13, 2023 Configuration menu - View commit details
-
Copy full SHA for d20bf2e - Browse repository at this point
Copy the full SHA d20bf2eView commit details -
we don't need these show sensed or show logs anymore!
Abby Wheelis committedSep 13, 2023 Configuration menu - View commit details
-
Copy full SHA for f132056 - Browse repository at this point
Copy the full SHA f132056View commit details -
factor out "Locations" and "Motion Type"
these two options are not supported, so we should not present them to the user -- removing them leaves us with one option, so no need for an options menu This reduces the complexity of the sensed data page significantly note about removing options: e-mission#1029 (comment)
Abby Wheelis committedSep 13, 2023 Configuration menu - View commit details
-
Copy full SHA for 723c5e7 - Browse repository at this point
Copy the full SHA 723c5e7View commit details -
combine dev-errors into errors
Abby Wheelis committedSep 13, 2023 Configuration menu - View commit details
-
Copy full SHA for d04d5ee - Browse repository at this point
Copy the full SHA d04d5eeView commit details
Commits on Sep 14, 2023
-
create a React version of ControlCollectionHelper and ControlSync Helper. These hold the logic for interfacing with the plugins, as well as UI elements for editing menus and various alerts / messages The place this is being stored has also changed, we no longer need to import from the other repos These helpers will eliminate the last parts of React routing, and allow us to no longer rely on the broadcast of "control update complete" to ensure the UI stays up to date
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 5e7a50c - Browse repository at this point
Copy the full SHA 5e7a50cView commit details -
medium accuracy switch was broken, now can be toggled smoothly
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 9255675 - Browse repository at this point
Copy the full SHA 9255675View commit details -
remove update complete listeners
no longer needed, as refreshCollect settings is called after toggling accuracy, toggling tracking, and when the settings editor is closed
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 1b8a43c - Browse repository at this point
Copy the full SHA 1b8a43cView commit details -
no longer rely on settingsScope to catch recomputeAppStatus, because we check on resume, this is not needed
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 9078488 - Browse repository at this point
Copy the full SHA 9078488View commit details -
the debouncing patch for toggleLowAccuracy is no longer needed!
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for e02db4a - Browse repository at this point
Copy the full SHA e02db4aView commit details -
prevent "missing argument errors"
since these arguments are optional, and we render based on their existence, set the default to undefined
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for d55760f - Browse repository at this point
Copy the full SHA d55760fView commit details -
no longer need to debounce, so no need to keep code around
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 2cb1145 - Browse repository at this point
Copy the full SHA 2cb1145View commit details -
isolate forceSync code to ControlSyncHelper
to start decluttering `ProfileSettings` move the component to the ControlSyncHelper then import it into `Profile Settings` by exporting a component, we can wrap the popups and their states into one place
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 1189700 - Browse repository at this point
Copy the full SHA 1189700View commit details -
don't store a duplicate copy of the collectConfig
this was one way I attempted to control the ControlSettings, but moved to set/get from a central location (plugin) for one-off changes (toggles) and using the local config, and saving once, when editing with the settings editor modal
Abby Wheelis committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for df78758 - Browse repository at this point
Copy the full SHA df78758View commit details
Commits on Sep 15, 2023
-
moving endForceSync and forceTransition into their respective helpers
Abby Wheelis committedSep 15, 2023 Configuration menu - View commit details
-
Copy full SHA for 1551eee - Browse repository at this point
Copy the full SHA 1551eeeView commit details -
Abby Wheelis committed
Sep 15, 2023 Configuration menu - View commit details
-
Copy full SHA for 1cfb190 - Browse repository at this point
Copy the full SHA 1cfb190View commit details -
Abby Wheelis committed
Sep 15, 2023 Configuration menu - View commit details
-
Copy full SHA for f012973 - Browse repository at this point
Copy the full SHA f012973View commit details
Commits on Sep 18, 2023
-
Abby Wheelis committed
Sep 18, 2023 Configuration menu - View commit details
-
Copy full SHA for c46e2dc - Browse repository at this point
Copy the full SHA c46e2dcView commit details -
for consistency and readability, re-writing the forceSync to rely on await rather than chained .then statements
Abby Wheelis committedSep 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 7f8ff42 - Browse repository at this point
Copy the full SHA 7f8ff42View commit details -
for readability, switch from chained .then statements to using await calls
Abby Wheelis committedSep 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 2876872 - Browse repository at this point
Copy the full SHA 2876872View commit details