Rewrite angular service - customURL #1042
Conversation
|
Please add this to "Ready for review" on the projects board: https://github.com/orgs/e-mission/projects/1 |
There was a problem hiding this comment.
Great work! LGTM!
I do think these changes are going to conflict with my changes in #1040 because this PR modifies join-ctrl.js, and join-ctrl.js no longer exists in my PR.
I think it's better to first get this PR merged into service_rewrite_2023 and then I can fix conflicts on my PR. In the future I will ensure that we use a better branch management strategy.
|
@jiji14 Since this PR has been open for 2 weeks and didn't get merged quickly, there are some fairly complex merge conflicts here. |
Yes, please 🆘 |
|
I addressed the merge conflicts. LGTM (as a side note, I am not sure that we actually need customURL moving forward as we no longer use links to trigger the onboarding flow. However, I think it's still useful to keep this around) |
…-mission-phone into rewrite_angular_service
JGreenlee
force-pushed
the
rewrite_angular_service
branch
from
9cc5657
to
4d86b37
Compare
…-mission-phone into rewrite_angular_service
Looks good to me too and I agree to keep it! 👍 |
|
I am merging for now, but we should remove it after ~ 1 year if we are not using it. |
Rewrite
customURL.jsangular serviceRelated Issue : e-mission/e-mission-docs#987
While rewriting the
customURL.js, I noticed thatCustomURL.onLaunchis only called once inhandleOpenURLinjoin-ctrl.js. I removed the angular event handlers$broadcastand$on, and instead, I directly called theonLaunchCustomURLwithinhandleOpenURL. As a result, I no longer needed the angular event handler incustomURL.ts.I added test cases with
valid urlandinvalid url.