Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✓ Updated "Verify Inference" Checkmark #1047

Merged
merged 4 commits into from
Oct 5, 2023
Merged

✓ Updated "Verify Inference" Checkmark #1047

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f6b737
Recentered & Resized "inferred trip" checkmark
the-bay-kay Sep 28, 2023
d3f8970
Checkmark dynamically appears, color matches
the-bay-kay Oct 2, 2023
6262d2e
Update www/js/survey/multilabel/MultiLabelButtonGroup.tsx
the-bay-kay Oct 3, 2023
9c36f7d
Update www/js/survey/multilabel/MultiLabelButtonGroup.tsx
the-bay-kay Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions www/js/survey/multilabel/MultiLabelButtonGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,12 @@ const MultilabelButtonGroup = ({ trip, buttonsInline=false }) => {
)
})}
</View>
<View>
<IconButton icon='check-bold' mode='outlined' size={16} onPress={verifyTrip}
disabled={trip.verifiability != 'can-verify'}
style={{width: 20, height: 20, margin: 3}}/>
</View>
{trip.verifiability === 'can-verify' && (
Copy link
Contributor

@shankari shankari Oct 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-bay-kay I see that this logic is unmodified, so I am going to merge it. But I would like to understand what it does, maybe illustrated with a short video.

From the code, it looks like if either button is yellow, we can "confirm" it. So if I had one yellow label and one blank label, I could press the confirm button and it would turn the yellow -> blue but leave the blank label unchanged.

Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the late reply! Here are two videos, comparing the old UI and the changes this added.

beforeVerify.mov
VerificationCheckmark.mp4

<View style={{marginTop:'1rem'}}>
the-bay-kay marked this conversation as resolved.
Show resolved Hide resolved
<IconButton icon='check-bold' mode='outlined' size={18} onPress={verifyTrip}
style={{width: 24, height: 24, margin: 3, backgroundColor: colors.secondaryContainer}}/>
the-bay-kay marked this conversation as resolved.
Show resolved Hide resolved
</View>
)}
</View>
<Modal visible={modalVisibleFor != null} transparent={true} onDismiss={() => dismiss()}>
<Dialog visible={modalVisibleFor != null} onDismiss={() => dismiss()}>
Expand Down
Loading