…to expand-enketo-helper

moving the methods form answer.js into enketoHelper as a part of the services migration

When testing, I was getting an error from Jest about duplicate modules, one of which was in platforms. This change resolves that error

additional test for filterByNameAndVersion

fake answers have been constructed to be filtered

completely remove answer.js and all references to it, replace references with references to enketoHelper.ts

resolveTimestamps is a helper function to saveResponse, but still contains a fair amount of its own logic. Testing the edge cases for this function ensures that it will behave as expected within the larger context

adding a basic test for _loadLazyConfig, in order to ensure that my mock setup for that works, before moving into testing functions that depend on it

currently struggling with i18next and MessageFormat, as I can't get either of those mocked and working

the message format plugin moved! https://github.com/messageformat/messageformat/tree/main/packages/core

setting __DEV__ to false in globals, so that it can be used throught the testing suit

calling the i18n setup in the tests should work once we incorporate the React testing changes

remove old i18n code, update types, comment out broken tests

from log statements, these answers have data and metadata, no labels

ensured that tests still pass

with the changes from e-mission#1049, we are now able to test using i18n, no need to mock!

introduced i18next for the tests

updated config in mock, and test of loading config to be accurate to what is expected (missing some '{' )

adjust formatting of function indentation

now that I understand how this function works, I got the xml (filled and unfilled) directly from console.log statements. The tests are now accurate, and cover each of the cases.

testing for saving the response, both when it works and when the  timestamps are invalid, resulting in an error

based on looking at these variables in breakpoints, these typings are more accurate

the mismatch of precision and expected precision here is what was causing the added time entries to fail

there were errors because I was accessing with window.cordova instead of window['cordova']

after the change from miliseconds to seconds, the expected output here changed

e-mission#1063 (comment)

…-mission-phone into expand-enketo-helper

…s/e-mission-phone into expand-enketo-helper

e-mission#1063 (comment)

Moving the fake config into it's own file so that we can easily add onto it. I kept the survey portion that I set up for the enketoHelper tests, and added the rest of the sections found in a typical config.

e-mission#1063 (comment)

…and-enketo-helper

verified that jest tests still run

…and-enketo-helper

…-mission-phone into expand-enketo-helper

With this change, the `formPath` specifying the URL of an Enketo survey can be either JSON or XML.
If it's JSON, we'll be able parse and use it directly. If it cannot be parsed as JSON, we'll perform XML -> JSON transformation with enketo-transformer/web.

the enketoHelper tests were failing because one of the files in the added directory was not transpiled ,so it was picking up as bad syntax

this file does not exist in this branch!

…-mission-phone into expand-enketo-helper

- Restore the use of 'filterByNameAndVersion' for trip confim surveys (not currently used for anything else). If a survey response is no longer compatible according to the appConfig, it should be filtered out here.
- Make the terminology unambiguous such that "answer" means how the user answered a particular question within the survey, and "response" means the overall survey response
- Clean up / clarify comments
- Remove unused import statements

now that Unified Data Loader has been merged, we can test this function, may benefit from more end-to-end testing later, as it relies on the usercache plugin heavily

The root of the issue I was having is that filterByNameAndVersion returns a promise, but it was being assigned to the unprocessedLabels var before the promise was fulfilled, adding the fiter.then() flow resolved this

we also want to test that the timestamps follow the "minute" accuracy convention we implemented, so that if the survey and timelineEntry match within the minute, we use the timelineEntry timestamps, else use the timestamps from the survey e-mission#1063 (comment)

this form is invalide because of the start and end times mismatching

the function was not all that necessary, so I removed it

Also moved my survey config type into the appropriate place

e-mission#1063 (comment)

adding a response that should get filtered out because the version is too low e-mission#1063 (comment)

Because of the new parameter, I was able to add more test cases to resolve Labels

I needed to also clear the locally stored config out of dynamicConfig.ts

from @JGreenlee's suggestion in review

Co-authored-by: Jack Greenlee <JackAGreenlee@gmail.com>

not all (in fact many) of the tests don't need this config at all, so the parameter should be optional to clean things up

Co-authored-by: Jack Greenlee <JackAGreenlee@gmail.com>

follow-on to making the config an optional parameter to mockBEMUserCache

Instead of passing it in EVERY TIME, it is now a fallback, and the config only needs to be specified and re-specified in the enketoHelper tests

added fallback and removed specification from tests that didn't need it

-add types for the parameters of resolveTimestamps
-update doc of this function
-cast 'timelineEntry' to trip or place where needed
-add a few fields that were missing from type defs of ConfirmedPlace and EnketoSurveyConfig

if the survey doesn't use start and end times, timestamps will be null. This is fine and we can use optional chaining to prevent throwing an error here

…s/e-mission-phone into expand-enketo-helper