Shared Type & Interface Declarations #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-bay-kay
added a commit
to the-bay-kay/e-mission-phone
that referenced
this pull request
Oct 26, 2023
- Updated types to match PR e-mission#1073 - Part of the motivaiton for this is that `/dairy/services.js` also relies on unifiedDataLoader; if this is written using those types, then that rewrite can build off of this rewrite without any additional merge conflicts down the road.
the-bay-kay
added a commit
to the-bay-kay/e-mission-phone
that referenced
this pull request
Oct 27, 2023
not needed since we are now keeping diaryTypes as js/types/diaryTypes.ts
- these types are used by timelineHelper
|
@the-bay-kay Did you see the PR I submitted to you last week the-bay-kay#1 ? |
My bad!! I completely missed the notification - just merged the changes now, I'll keep a better eye on the PR's tab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to create a set of type interfaces & declarations that mimic the classes and objects found in e-mission-server. This should help standardize typing across the angular service rewrites (Issue 977), and should help future function design.
This discussion originally started in PR #1061 - the overall design philosophy is to have higher-level interfaces (e.g.,
ServerData), which can then be extended to more specific "sub-classes" of server data in separate type files.