Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hybrid #1075

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Add hybrid #1075

merged 4 commits into from
Oct 30, 2023

Conversation

Abby-Wheelis
Copy link
Member

This PR will accomplish the changes proposed in issue #1013

Abby Wheelis added 2 commits October 21, 2023 16:08
added hybrid car to label-options file and to en i18n
@Abby-Wheelis
Copy link
Member Author

I will start a translate PR for this after everything settles with the re-work of the label translations is wrapped up

@Abby-Wheelis Abby-Wheelis changed the base branch from service_rewrite_2023 to add_labeling_screen October 23, 2023 16:20
@Abby-Wheelis Abby-Wheelis changed the base branch from add_labeling_screen to service_rewrite_2023 October 23, 2023 16:20
@Abby-Wheelis Abby-Wheelis changed the base branch from service_rewrite_2023 to onboarding_routing_sept_2023 October 23, 2023 16:35
@Abby-Wheelis Abby-Wheelis changed the base branch from onboarding_routing_sept_2023 to service_rewrite_2023 October 23, 2023 16:35
@Abby-Wheelis Abby-Wheelis marked this pull request as ready for review October 27, 2023 22:38
@Abby-Wheelis
Copy link
Member Author

This was based on the feature branch (onboarding_routing), so that one may need to be merged into this branch first

@shankari shankari changed the base branch from service_rewrite_2023 to master October 29, 2023 02:02
@shankari shankari changed the base branch from master to service_rewrite_2023 October 29, 2023 02:02
Copy link
Contributor

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abby-Wheelis I am fine with the two actual commits in the PR.
However, it looks like there are several other file changes here as well, and they are staying even after we have merged from main to service_rewrite_2023
e.g.

{ /* If we are fully consented, (route > PROTOCOL), the permissions popup can show if needed.
already includes the diff in App.tsx here.

If you can't figure out how this happened, you may want to just close this PR and create a new one to make sure that it is clean.

@Abby-Wheelis Abby-Wheelis changed the base branch from service_rewrite_2023 to master October 29, 2023 02:25
@Abby-Wheelis Abby-Wheelis changed the base branch from master to service_rewrite_2023 October 29, 2023 02:25
@Abby-Wheelis Abby-Wheelis changed the base branch from service_rewrite_2023 to master October 30, 2023 15:16
@Abby-Wheelis Abby-Wheelis changed the base branch from master to service_rewrite_2023 October 30, 2023 15:16
@Abby-Wheelis
Copy link
Member Author

I was able to resolve the diffs to just be the relevant changes by merging upstream and toggling the target branch

@shankari shankari merged commit 5b725a1 into e-mission:service_rewrite_2023 Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants