-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hybrid #1075
Add hybrid #1075
Conversation
added hybrid car to label-options file and to en i18n
I will start a translate PR for this after everything settles with the re-work of the label translations is wrapped up |
This was based on the feature branch ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abby-Wheelis I am fine with the two actual commits in the PR.
However, it looks like there are several other file changes here as well, and they are staying even after we have merged from main to service_rewrite_2023
e.g.
e-mission-phone/www/js/App.tsx
Line 94 in 7338c18
{ /* If we are fully consented, (route > PROTOCOL), the permissions popup can show if needed. |
App.tsx
here.
If you can't figure out how this happened, you may want to just close this PR and create a new one to make sure that it is clean.
I was able to resolve the diffs to just be the relevant changes by merging upstream and toggling the target branch |
This PR will accomplish the changes proposed in issue #1013