Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final showstopper issue #1087

Merged
merged 7 commits into from
Oct 28, 2023
Merged

Final showstopper issue #1087

merged 7 commits into from
Oct 28, 2023

Commits on Oct 24, 2023

  1. add more url checks

    we need to make sure that nobody scans a random qr code and gets into the app with an invalid token, we can help prevent that by checking that the qr code contains the right elements
    Abby Wheelis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ea49921 View commit details
    Browse the repository at this point in the history
  2. updates to check code

    added a log statement, and verifying that the first part of the opcode is "nrelopenpath" or "emission" -- the staging opcodes start with "emission", but sometimes we use production opcodes to test things in develpoment
    Abby Wheelis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5da3909 View commit details
    Browse the repository at this point in the history
  3. Update QrCode.tsx

    make sure qr code is made with the whole url link
    Abby Wheelis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6360519 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Use only emission externally

    Long term, this should be part of the app config
    e-mission/e-mission-docs#985 (comment)
    shankari authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    2d930f8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1081 from Abby-Wheelis/no-fishy-qr-codes

    💪 Increase checks for scanned QR code
    shankari authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8dfcd29 View commit details
    Browse the repository at this point in the history
  3. fix naming error

    when I updated the name of this visibility state, I did not update it's setter. This caused the popup to fail to launch
    Abby Wheelis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    29fac8a View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1082 from Abby-Wheelis/collection-stuck-bug

    🐛 Fix Edit Collection Settings
    shankari authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    17657a9 View commit details
    Browse the repository at this point in the history