Pull from master to service_rewrite_2023 #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Updated README like @JGreenlee mentioned to successfully build 2. Maintaining current version 3. Will update again after updating JDK in this intel machine
…ated certain resources
- Added hyperlink to the title - Added output screenshot
- Updating markdown anchors
Updating markdown anchors as 4,5, & 6 weren't working
- touch up - fixed non-working markdown anchors
Removed manual numbering and updated markdown anchors
…on 3. Revised formatting for activation sub-section -> for better clarity
1. Removed instructions on JAVA_HOME as it is no longer required 2. Quality of life changes
1. Changed the content section 2. Updated links in "Contributing" section 3. Updated "end to end testing" section
1. Updated buttons to point to the right CI 2. Removed point no. 4 in troubleshooting (it was empty)
Made sure the links for the buttons are correct
1. Removed manual numbering 2. Removed any form of version numbers 3. Removed certain Permalinks and swapped it with relative PATHs 4. Made sure the structure is same
iter 1 - fix end to end testing
Not required anymore
- Better wordings
- Removed relative PATH for dynamic links as they don't seem to work
Modified the server to `server`
there was an issue with the alert, which was showing a promise object rather than the actual result. This change works to resolve that issue
trying to ensure that the updates are complete by moving anything that happens after into the same function, after the await
setting a delay does prevent the collect settings changes from turning off tracking, but this is not a very principled fix, still looking for a better way to fix this
…. Added CI badge 3. Plugins installation guide updated
Adding suggested changes Co-authored-by: shankari <shankari@eecs.berkeley.edu>
Committing suggested changes Co-authored-by: Jack Greenlee <JackAGreenlee@gmail.com>
Committing changes based on suggestions - Wording - Listing common build types
in order to fix the bug, we're changing when we mark the consent in storage. Moving the call to after the user has agreed to both parts -- protocol AND permissions, prevents the early popup. For more discussion see: e-mission/e-mission-docs#1006 (comment)
Committing suggested change Co-authored-by: K. Shankari <shankari@eecs.berkeley.edu>
Committing change based on suggestion (adding a link that points to Noel-openpath-deploy-configs)
🚑 Patch for showstopping ios popup issue
…_sept_2023 Updated README for Label dashboard profile sept 2023
So that we can check that the tests are passing before we merge
…e run the CI on To avoid having to make a new branch and making everybody switch
Improve testing so we also run tests on feature branches
…into edit-tracking-bug
medium accuracy sometimes alters the tracking settings as well, this timeout resolves that
the prior variable name was inconsistent with the rest of the file, and therefore created confusion
Edit tracking bug
…n_bump Bumped up version for new location permissions release
we need to make sure that nobody scans a random qr code and gets into the app with an invalid token, we can help prevent that by checking that the qr code contains the right elements
added a log statement, and verifying that the first part of the opcode is "nrelopenpath" or "emission" -- the staging opcodes start with "emission", but sometimes we use production opcodes to test things in develpoment
make sure qr code is made with the whole url link
Long term, this should be part of the app config e-mission/e-mission-docs#985 (comment)
💪 Increase checks for scanned QR code
when I updated the name of this visibility state, I did not update it's setter. This caused the popup to fail to launch
🐛 Fix Edit Collection Settings
Final showstopper issue
Change the path where we expect gems to be installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.