Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier Setup (Merge to Service Rewrite Branch) #1094

Merged

Conversation

jiji14
Copy link
Contributor

@jiji14 jiji14 commented Nov 2, 2023

This PR follows #1068 #1084.
To review all the discussions regarding the formatting, please refer to the previous PR.
I created a new PR to maintain a clean and readable branch.
This will be merged to service_rewrite_2023.


Related Issue

For considerations regarding Prettier, please refer to the following GitHub issue: Prettier Issue #1014.


Configuration Options

Our team has carefully chosen these configuration options, which are based on discussions.
To explore more details, please visit the Prettier documentation on options.


How to Run Prettier

You can format your code using Prettier by running the following command:

npx prettier --write {filename}

Auto-Saving

If you wish to enable auto-saving locally, please follow these steps:

  1. Create a .vscode folder at the project's root directory.
  2. Inside the .vscode folder, create a settings.json file and include the following code:
{
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.formatOnSave": true
}
  1. Additionally, install the Prettier - Code formatter VSCode extension.

The next PR will set up GitHub Actions for Prettier and merge it to master branch.

Copy link
Contributor

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the main files, merging everything else without any review!

@shankari shankari merged commit 765fa00 into e-mission:service_rewrite_2023 Nov 2, 2023
1 check passed
@jiji14 jiji14 mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants