emailService Js -> ts #1097
emailService Js -> ts #1097
Conversation
niccolopaganini
commented
Nov 8, 2023
niccolopaganini
commented
- emailService Js -> ts
- modified files surrounding emailService
- Changed email address to Shankari's
Removed comments
Removed comments
Removed comments
Removed comments
|
Manual Testing done. Process:
|
|
@niccolopaganini as we discussed, please add a video of the testing done before requesting review. |
|
This is a video of the devapp |
|
Email received (in my work email address)
|
- remove unused imports - use logDebug, logInfo, logWarn, format nicely - replace ionic.Platform.isIOS / isAndroid with cordova.platformId
|
@JGreenlee @niccolopaganini I am merging this right now in the interests of progress, but I would like to see tests for this show up fairly soon. |
|
@shankari I didn't ask for unit tests on this PR because I didn't think it would be possible to test the functionality of sending an email (which is basically all this service does) We could mock the email plugin but then we're just testing the mock. Is there something else here that you see value to testing? |
|
@JGreenlee I agree that mocking is not helpful. However, it seems like it should be possible to use Appium to test that the email client is launched successfully to at least check for issues like https://github.com/katzer/cordova-plugin-email-composer/issues wrt checking whether the email is actually sent, we just need a service that lets you sent throwaway emails to it and then check their receipt via API. So something like https://testmail.app/ (there might be alternatives, we should look around a bit). Note that we will need to get permission from IT before using any external service, and this is likely to take a few weeks at the minimum. |
Once we have Appium integrated, this might be possible in an Android emulator – but I am pretty sure it's not going to be achievable on the iOS Simulator because it doesn't support email at all. Even so, I'm not sure if Appium can detect an external app launch. I think Appium attaches itself to the app it's targeted at and I'm not sure if it can detect anything from other apps.
This would be a function of the email client app (e.g. Gmail); why would we have to test an app that isn't ours? Isn't that beyond the scope of this project? |
Correct, it would only be in an android emulator.
It would be interesting to know that. If not, I guess we must maintain a (hopefully short) list of tests that must be performed manually and add this there.
Well, we invoke gmail, and it would be good to know if we do so correctly. For example, if a merge conflict resulted in the email address being munged (e.g. foobar@goobar.commereefe), we would want to know. Similarly, if there is an error in exporting the logs, we would want to know. It would help us find issues like e-mission/e-mission-docs#994 FYI, another email checking service: |
