Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“Ÿ πŸ› οΈ Update setup_ios_native.sh to support Apple Silicone #1116

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

the-bay-kay
Copy link
Contributor

Homebrew installs packages differently depending on chip architecture. As such, the native-build setup script needed a quick update to support M1-chip machines!

I have yet to try this on an Intel machine (I don't have another Mac on hand), so any help testing the adjusted setup script would be greatly appreciated!

Homebrew installs packages differently depending on chip
architecture -- updated the setup script to reflect this difference.
@shankari
Copy link
Contributor

shankari commented Dec 9, 2023

@the-bay-kay we build as part of the CI (osx-build-ios). You can check to see which chip it is running on. It might be worthwhile looking at whether we can check both M1 and Intel as part of the CI by configuring it accordingly.

@shankari
Copy link
Contributor

checked it myself, found

Found x86_64 chip

So merging.

@the-bay-kay can you please submit a new PR that will run this on M1 chips as well?
https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

@shankari shankari merged commit 4715968 into e-mission:master Dec 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Address code reviews with "future"
Development

Successfully merging this pull request may close these issues.

2 participants