-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👤🔊 OP Accessibility: Screen Reader Improvements #1118
Commits on Nov 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7d60bdc - Browse repository at this point
Copy the full SHA 7d60bdcView commit details
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9d970d2 - Browse repository at this point
Copy the full SHA 9d970d2View commit details
Commits on Dec 6, 2023
-
Removed open-access study link, added button roles to existing button…
…s, note-translation not found for more info button
Configuration menu - View commit details
-
Copy full SHA for 120059c - Browse repository at this point
Copy the full SHA 120059cView commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 69e3bee - Browse repository at this point
Copy the full SHA 69e3beeView commit details
Commits on Dec 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2620ad6 - Browse repository at this point
Copy the full SHA 2620ad6View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3ed90d5 - Browse repository at this point
Copy the full SHA 3ed90d5View commit details
Commits on Jan 2, 2024
-
Fix disconnected text/button for accessibility for logout
- Added onPress to the entire TouchableOpacity, so that both the text and icon are clickable - Added aria-hidden for IconButton
Configuration menu - View commit details
-
Copy full SHA for f359bfc - Browse repository at this point
Copy the full SHA f359bfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f12bf5a - Browse repository at this point
Copy the full SHA f12bf5aView commit details -
Add accessibilityLabel properties to the navigation menu
The BottomNavigation element provided by React Paper allows us to set an accessibilityLabel for each route button. Paper defaultly creates 2 text fields for each route (whether there's an accessibilityLabel, or themes present at all). One of them displays the text for the route, and the other is a exact-identical element, but has its opacity changed to 1 when its route is not-selected, and 0 when its route is selected. This appears to be so that the text is thicker when it is not selected, and thinner when it is selected. My hope is that the screen reader will pick up this accessibilityLabel, and not read the internal text fields.
Configuration menu - View commit details
-
Copy full SHA for 2b41759 - Browse repository at this point
Copy the full SHA 2b41759View commit details
Commits on Jan 9, 2024
-
Remove non-character characters
For accessibility improvements, see translations in e-mission/e-mission-translate#53
Configuration menu - View commit details
-
Copy full SHA for e3e1461 - Browse repository at this point
Copy the full SHA e3e1461View commit details -
Remove focusability for SettingRow icons
Accessibility and screen readers do not necessarily need to know what the text is of what the icon is supposed to be representing, and the React Native Paper element for List.Icon does not handle accessibilityLabel (the accessibilty label that is produced is undefined, [] empty box)
Configuration menu - View commit details
-
Copy full SHA for 8d8a40f - Browse repository at this point
Copy the full SHA 8d8a40fView commit details -
Change accessibilityRole for ExpandMenu "developer zone" to spinbutto…
…n instead of button React Native Paper does not handle AccessibiltyRole, so we have to just rename the accessibility text to include "spinbutton" to identify this object as a spinbutton. I am going with the expectation that accessibility elements in other languages (e.g. Spanish, Lao) use the same names for objects, such as "spinbutton", "button", etc. because this won't be translated
Configuration menu - View commit details
-
Copy full SHA for dd1f404 - Browse repository at this point
Copy the full SHA dd1f404View commit details
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 771cb15 - Browse repository at this point
Copy the full SHA 771cb15View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd9b2f2 - Browse repository at this point
Copy the full SHA bd9b2f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b7b51 - Browse repository at this point
Copy the full SHA d5b7b51View commit details
Commits on Jan 22, 2024
-
Change logout button from TouchableOpacity to a List.item
This way, the accessibility DOM sees it as one single clickable button, and does not attempt to focus on the text ever. I modeled this after the settingsrow buttons, which use List.Icon as well.
Configuration menu - View commit details
-
Copy full SHA for b94abff - Browse repository at this point
Copy the full SHA b94abffView commit details
Commits on Feb 5, 2024
-
Merge branch 'service_rewrite_2023' of https://github.com/e-mission/e…
…-mission-phone into screen-reader
Configuration menu - View commit details
-
Copy full SHA for 44ac249 - Browse repository at this point
Copy the full SHA 44ac249View commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c4798c6 - Browse repository at this point
Copy the full SHA c4798c6View commit details
Commits on Feb 9, 2024
-
Undoing desc and descriptionText changes in www/js/control/SettingRow…
….tsx These are old changes from before I took over the PR, I can go ahead undo them
Configuration menu - View commit details
-
Copy full SHA for 3090f33 - Browse repository at this point
Copy the full SHA 3090f33View commit details -
Undoing desc and descriptionText changes in www/js/control/SettingRow…
….tsx These are old changes from before I took over the PR, I can go ahead undo them
Configuration menu - View commit details
-
Copy full SHA for b0596e0 - Browse repository at this point
Copy the full SHA b0596e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf7c860 - Browse repository at this point
Copy the full SHA cf7c860View commit details