-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations Cleanups #1121
Translations Cleanups #1121
Conversation
…nslation-cleanup-jan24
noted that with the phone in Spanish, the date was still showing in English. Setting the locale resolves this
Jest test failing over the date format -- I may need to evaluate and update the test, but it says that the function does not exist ... working in the emulator though? My next step will be to run the Jest tests locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## service_rewrite_2023 #1121 +/- ##
========================================================
+ Coverage 58.80% 58.83% +0.02%
========================================================
Files 26 26
Lines 1420 1421 +1
Branches 320 320
========================================================
+ Hits 835 836 +1
Misses 585 585
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Found some translation issues when editing the postcard a few weeks ago:
diaryHelper.ts
to internationalize dates on the trip card