Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations Cleanups #1121

Merged

Conversation

Abby-Wheelis
Copy link
Member

Found some translation issues when editing the postcard a few weeks ago:

  • updated the active minutes to be fully translated
  • updated diaryHelper.ts to internationalize dates on the trip card

Abby Wheelis added 4 commits January 2, 2024 11:34
noted that with the phone in Spanish, the date was still showing in English. Setting the locale resolves this
@Abby-Wheelis Abby-Wheelis marked this pull request as ready for review January 2, 2024 20:30
@Abby-Wheelis
Copy link
Member Author

Jest test failing over the date format -- I may need to evaluate and update the test, but it says that the function does not exist ... working in the emulator though? My next step will be to run the Jest tests locally

@Abby-Wheelis
Copy link
Member Author

Fixed code, Jest runs now, as it turns out I needed to set the locale first, not in a chain. I'm honestly not sure why it worked in the emulator, but it still works and is now the correct syntax:

 t.locale(i18next.language);
  return t.format('ddd LL');

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ffa629) 58.80% compared to head (6e3af4f) 58.83%.
Report is 7 commits behind head on service_rewrite_2023.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           service_rewrite_2023    #1121      +/-   ##
========================================================
+ Coverage                 58.80%   58.83%   +0.02%     
========================================================
  Files                        26       26              
  Lines                      1420     1421       +1     
  Branches                    320      320              
========================================================
+ Hits                        835      836       +1     
  Misses                      585      585              
Flag Coverage Δ
unit 58.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
www/js/diary/diaryHelper.ts 72.91% <100.00%> (+0.57%) ⬆️

Copy link
Collaborator

@JGreenlee JGreenlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shankari shankari merged commit c91e8c0 into e-mission:service_rewrite_2023 Jan 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants