🩹 fix crash on updatePrefReminderTime #1130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user updates the "Time of Day for Reminders", it will store as "Invalid DateTime" and cause a crash.
This fix ensures that the selected time will be stored, and "Invalid DateTime" will not get stored.
But if any user had already encountered this, and "Invalid DateTime" was already stored to their profile, they would still not be able to access the Profile screen without it crashing.
So the second change makes sure
notifScheduler
only attempts to schedule notifications if the datetime is valid.If not valid, user will see this popup:
After dismissing the popup, they can change their "Time of Day for Reminders" and it will set correctly this time