Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fermata fixes apr17 #1146

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Fermata fixes apr17 #1146

merged 3 commits into from
Apr 20, 2024

Commits on Apr 17, 2024

  1. UserInputButton: before appConfig is defined, don't show default survey

    @JGreenlee
    JGreenlee committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8cc6a7e View commit details
    Browse the repository at this point in the history

  2. in updateUnprocessedBleScans, await call to getUnifiedDataForInterval 

    Without the 'await' keyword here, execution would continue without the request being completed.
This would cause the BLE scans to sometimes not be considered while rendering and evaluating conditional surveys.
If the BLE scans took longer to load than the trips took to render, there would be no surveys prompted.
Thus, we must 'await' to make sure the BLE scans are loaded first.
    @JGreenlee
    JGreenlee committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    03673a4 View commit details
    Browse the repository at this point in the history

  3. cacheResourcesFromConfig: reload the cache when config is downloaded 

    We recently added the ability to refresh the config from inside the app.
But whenever the config is downloaded for the first time, we cache the resources referenced in it by URL. Subsequent config downloads would still use the resources from the first time.

fetchUrlCached now accepts options to pass through to the fetch API; if cache is 'reload', we will skip checking our localStorage cache for a previously stored value. This option will also cause the fetch API will also skip its own internal cache

The result of this is that when we refresh the config, URL-referenced resources inside it will also be refreshed.
    @JGreenlee
    JGreenlee committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d83f4d4 View commit details
    Browse the repository at this point in the history