💚 👷 Remove the check for patcher #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed patcher in 41ff1a7 so we should not expect to see it in the file structure any more This should fix the failing build ``` + ls -al /tmp/new-install/Android/sdk + '[' '!' -d /tmp/new-install/Android/sdk/emulator ']' + '[' '!' -d /tmp/new-install/Android/sdk/build-tools ']' + '[' '!' -d /tmp/new-install/Android/sdk/patcher ']' + exit 1 ``` Also, run CI on changes to the SDK package list (i.e. `setup/android_sdk_packages`) so that such errors are caught in the PR stage in the future
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 26.40% 26.40%
=======================================
Files 114 114
Lines 4983 4983
Branches 1028 1064 +36
=======================================
Hits 1316 1316
+ Misses 3667 3665 -2
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed patcher in 41ff1a7 so we should not expect to see it in the file structure any more
This should fix the failing build
Also, run CI on changes to the SDK package list (i.e.
setup/android_sdk_packages) so that such errors are caught in the PR stage in the future