Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 ⬆️ Upgrade the pinned version of the runner to 14-large #1153

Merged
merged 3 commits into from
May 5, 2024

Conversation

shankari
Copy link
Contributor

@shankari shankari commented May 5, 2024

This should still have the correct environment variable because 14-large runs x64 https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

macos-14 now runs amd, and we have to figure out how to run it. Maybe we can run both as part of a schedule instead of on every pull request

This should still have the correct environment variable because `14-large` runs x64
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

`macos-14` now runs amd, and we have to figure out how to run it.
Maybe we can run both as part of a schedule instead of on every pull request
@shankari
Copy link
Contributor Author

shankari commented May 5, 2024

Failure is

Requested labels: macos-14-large
Job defined at: e-mission/e-mission-phone/.github/workflows/android-build.yml@refs/pull/1153/merge
Waiting for a runner to pick up this job...
Job is waiting for a hosted runner to come online.

Yup.
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Let's go back to macos-14, which is actually now an arm64 machine

macOS 14 Arm64 	macos-latest, macos-14, macos-latest-xlarge or macos-14-xlarge

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.40%. Comparing base (f504f68) to head (2eabfb8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   26.40%   26.40%           
=======================================
  Files         114      114           
  Lines        4983     4983           
  Branches     1064     1069    +5     
=======================================
  Hits         1316     1316           
  Misses       3665     3665           
  Partials        2        2           
Flag Coverage Δ
unit 26.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@shankari shankari merged commit 4ec96df into e-mission:master May 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant