Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timeline initial date range regression #1162

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix timeline initial date range regression #1162

merged 1 commit into from
Jun 25, 2024

Commits on Jun 7, 2024

  1. fix timeline initial date range regression 

    When refactoring into TimelineContext, there was a regression regarding the date range that is initially loaded.
e-mission#1142 (comment)

It used to load 7 days before the pipelineEnd up to today. After the change, it would load 7 days before today up to today.
If the user has travel everyday this ends up being equivalent. But if there isn't recent travel, this becomes a problem.

So in TimelineContext, the initial dateRange needs to depend on pipelineRange. instead of giving an initial value upfront, we'll let dateRange be null until pipelineRange is set, at which point we'll also set dateRange.
This means we have to consider some extra cases where dateRange can be null.
    @JGreenlee
    JGreenlee committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1955618 View commit details
    Browse the repository at this point in the history