Point QR code scanner plugin to e-mission repo #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
- Coverage 30.59% 30.36% -0.24%
==========================================
Files 118 118
Lines 5216 5256 +40
Branches 1154 1106 -48
==========================================
Hits 1596 1596
- Misses 3618 3658 +40
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. |
louisg1337
changed the title
|
@louisg1337 You should also bump up the data collection plugin to get the new version with the additional logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
package.cordovabuild.jsonto point to e-mission's custom QR code scanner plugin which will fix weird iOS glitch found in issue below. The changes to the plugin can be found here.