Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picked from location history #738

Merged
merged 3 commits into from
Feb 18, 2021

Commits on Feb 18, 2021

  1. Improve the matching of user inputs to cleaned trips

    While matching user inputs on the server, found that user input matching was
    broken for some cleaned trips on the phone.
    e-mission/e-mission-docs#476 (comment)
    
    Expanded the user input end check to fix.
    e-mission/e-mission-docs#476 (comment)
    
    Will merge into master after additional testing on the branch.
    
    + bump up the allowed delta to 15 minutes since the time threshold default for
    the distance filter is 10 minutes.
    shankari committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    a70569e View commit details
    Browse the repository at this point in the history
  2. Fix regression in enhanced trip matching

    The enhanced trip matching (75129db) caused a
    regression in which a spurious trip (not a trip) that occurred after the real
    trip fit the criteria for a match.
    
    And since it was confirmed after the real trip, as you would expect while going
    down the trip list, it was matched preferentially.
    e-mission/e-mission-docs#476 (comment)
    
    Fixed by checking the degree over overlap and rejecting too short matches
    shankari committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    418f150 View commit details
    Browse the repository at this point in the history
  3. Fix the infinite scroll user input matching

    to be consistent with the refactor in
    21ab3fa
    and
    6bd731a
    shankari committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    4f70194 View commit details
    Browse the repository at this point in the history