View QR Code Row #827
Open
View QR Code Row #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a row to the profile screen to view qr code. Pressing the icon creates a popup where qr code will go.
shankari
requested changes
May 17, 2022
| } | ||
|
|
||
| $scope.viewQRCode = function($event) { | ||
| i18nUtils.geti18nFileName("templates/", "control/qrc", ".html").then((qrcFileName) => { |
There was a problem hiding this comment.
you don't need the QR code template to be internationalized.
Comment on lines
+1
to
+3
| <script src="/node_modules/qrcode-generator/js/qrcode.js"></script> | ||
| <script src="/node_modules/qrcode-generator/js/qrcode_UTF8.js"></script> | ||
| <script src="/node_modules/angular-qrcode/angular-qrcode.js"></script> |
There was a problem hiding this comment.
You need to have this module in package.json. Otherwise, anybody else who installs the app using setup_serve.sh will not have this module.
Also, the code in /node_modules is typically not available to the app. Are you sure this works? You need to install it using bower, or temporarily copy the files into www/manual_lib and check it in. Temporarily until we move to a build system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a row to the profile screen to view qr code. Pressing the icon creates a popup where qr code will go.