Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default screen to Dashboard #880

Open
wants to merge 1 commit into
base: single_tenant_app_snapshot_unmaintained
Choose a base branch
from

Conversation

sebastianbarry
Copy link
Contributor

startprefs.js

  • replaced inf_scroll as being the default open screen, to Dashboard (aka metrics)

startprefs.js
- replaced inf_scroll as being the default open screen, to Dashboard (aka metrics)
@sebastianbarry
Copy link
Contributor Author

sebastianbarry commented Aug 24, 2022

Success, here is the testing:

Screen.Recording.2022-08-23.at.11.14.29.PM.mov
Screen.Recording.2022-08-23.at.11.15.10.PM.mov

Copy link
Contributor

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shankari
Copy link
Contributor

This is a pretty substantial change, so I am going to send out a note to existing program admins and merge it in the next round, along with the other UI improvements to the onboarding flow.

@shankari
Copy link
Contributor

@sebastianbarry can you fix this before you leave?
we should also expand this to be dynamically configurable

  • if the survey type is ENKETO, then we won't even show the dashboard (already implemented)
  • if the survey type is MULTILABEL, then we should have a flag which indicates whether label or dashboard should be the default

I remember Durham saying that they didn't want dashboard to be the default, which is why I didn't merge this to begin with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants