Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Lao to survey #999

Merged

Conversation

Abby-Wheelis
Copy link
Member

Alongside the work in e-mission translate, e-mission translate PR#31, the survey file needed to be updated to include Lao language support

replaced survey file with one that includes Lao translations
@Abby-Wheelis Abby-Wheelis changed the base branch from master to master_for_platform June 30, 2023 17:45
@shankari
Copy link
Contributor

shankari commented Jul 6, 2023

High level comments:

That should be it! You can then change this from draft and I can merge.

@shankari shankari changed the base branch from master_for_platform to framework_migration_prep July 6, 2023 20:42
@shankari
Copy link
Contributor

shankari commented Jul 6, 2023

Let's merge this also to framework_migration_prep for now since I will be pulling from there for the next release

Abby Wheelis added 2 commits July 6, 2023 15:14
@Abby-Wheelis
Copy link
Member Author

I eventually update just the xls file, the extra commits are because I accidentally committed changes from locales (which I did not want to do). Sorry! I know I'm making things more confusing, I'm still learning GitHub

@shankari
Copy link
Contributor

shankari commented Jul 6, 2023

No worries. Learning is what you do when you are an intern.
If this is ready to merge, move it out from draft, and I will squash merge

@shankari
Copy link
Contributor

shankari commented Jul 6, 2023

Don't forget to copy over the final json into www/json!

@Abby-Wheelis Abby-Wheelis marked this pull request as ready for review July 6, 2023 21:30
@shankari
Copy link
Contributor

shankari commented Jul 7, 2023

It's hard to review this because the changes are so large. So I'm going to merge and rely on the testing!

@shankari shankari merged commit e32f950 into e-mission:framework_migration_prep Jul 7, 2023
@shankari
Copy link
Contributor

shankari commented Jul 7, 2023

@Abby-Wheelis squash merged this as well to avoid blame churn

@Abby-Wheelis Abby-Wheelis deleted the Lao-updates branch July 7, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants