Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations Cleanup #52

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Conversation

Abby-Wheelis
Copy link
Member

@Abby-Wheelis Abby-Wheelis commented Jan 2, 2024

  • Add missing error keys
  • correct mistakes in the Spanish translations
  • remove stale multilabel keys Reverted based on the discussion in this thread

Abby Wheelis added 3 commits January 2, 2024 11:16
there are some new error messages in the service-rewrite-2033 branch, which will soon become a part of the main branch
one key was not translated
another key missrepresented the date
@Abby-Wheelis Abby-Wheelis marked this pull request as ready for review January 2, 2024 20:30
lo/i18n/lo.json Outdated
Comment on lines 401 to 402
"while-initializing-label": "While initializing Label tab: ",
"while-loading-pipeline-range": "Error while loading pipeline range",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fill these in with translations from Google Translate on the principle that something is better than nothing?

Copy link
Member Author

@Abby-Wheelis Abby-Wheelis Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made these updates in b9d8516

es/i18n/es.json Outdated
Comment on lines 400 to 401
"while-initializing-label": "While initializing Label tab: ",
"while-loading-pipeline-range": "Error while loading pipeline range",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have to be the spanish translations, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates made in ef9628e

@shankari shankari merged commit e802f63 into e-mission:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants