Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new translations to es and lo #58

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

JGreenlee
Copy link
Collaborator

@JGreenlee JGreenlee commented Sep 20, 2024

Adds translations needed for e-mission/e-mission-phone#1176, plus other translations that I have noticed are missing

For translations that were simply moved, the key renamed, or slightly modified, I used the old translations as a base.
For new translations, I largely used Google Translate for Lao and a combination of Google Translate and Reverso (which is more context-aware than Google Translate) for Spanish

Adds translations needed for e-mission/e-mission-phone#1176, plus other translations that I have noticed are missing
Copy link
Member

@Abby-Wheelis Abby-Wheelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Spanish translations look good to me! I can send the Lao translations side-by-side with the English to the team in Laos, but that will likely take a few days to hear back. If you, you want to merge now and I can polish later with any updates that they send back.

@JGreenlee
Copy link
Collaborator Author

The Spanish translations look good to me! I can send the Lao translations side-by-side with the English to the team in Laos, but that will likely take a few days to hear back. If you, you want to merge now and I can polish later with any updates that they send back.

That would be great!

@JGreenlee JGreenlee merged commit de7f70e into e-mission:master Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tasks completed
Development

Successfully merging this pull request may close these issues.

2 participants