Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup (Join) #2 - Tasks: A-5 #34

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 21, 2024

  1. Task A-6: Switching to step outputs instead of GITHUB_ENV

    Refer to details in cleanup issue:
    Task A-6: e-mission/e-mission-docs#1082 (comment)
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    991e369 View commit details
    Browse the repository at this point in the history
  2. Task A-2: Storing latest tag in .env file + Task A-8: Prefix branch name

    Refer to details in cleanup issue:
    Task A-2: e-mission/e-mission-docs#1082 (comment)
    
    Storing latest tag as well so that artifacts are not needed.
    
    For now not removing artifacts until the internal script is updated to handle this change.
    
    ----
    
    Task A-8: Prefixing branch name to the docker tag along with the date.
    In the internal script we will not need to maintain the different branch lists as the images will be completely tagged in the external workflows themselves.
    We can simply use the tags without modifications then.
    
    For now, not prefixing the tag to the artifact since we will be removing the artifact anyways.
    And current internal script works with artifacts.
    Once I update the internal script, will come back and remove artifacts.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    107fe0b View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Task A-2: Removed artifact upload ; internal script updated

    Internal script updated as well.
    Internal PR must be merged as well once these external PR changes merged.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    acb9f3a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Task A-5: Added reusable workflow

    Storing a reusable workflow in the e-mission-server repo. Can decide where to place it in a central location.
    https://docs.github.com/en/actions/sharing-automations/reusing-workflows
    
    It essentially works like a function call in normal programming.
    The advantage is that we have no repeated code the image build process.
    All the other repos (join, admin-dash, public-dash) reuse the same workflow file.
    
    Additionally, on for future GitHub actions, workflow file related changes, will no longer need to have 3 additional PRs for each repo (join, admin-dash, public-dash). Can simply modify the reusable workflow file as this is the core “function” workflow that is being called.
    
    I have added conditional checks that check for the repo name in the reusable workflow file that determine which statements to execute depending on for which repo the workflow is running.
    
    This is used for both push events specific to a repo as well as for the workflow dispatch events triggered on pushes to server repo.
    MukuFlash03 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    24460cf View commit details
    Browse the repository at this point in the history