TEP-1015: price data #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH-36 [skip ci] Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
[skip ci] Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
GH-40 Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
* Historic price data * Inverted prices * Price conversion chains Clarified PriceEntry Add future ideas about reporting date for prices Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Add Muhammad Ragib Hasin to Contributors Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
This is jiff Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Known issue: * First column of register report is not converted
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
price-{00,01,02,03,05}
GH-36
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
GH-36 Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
* [ ] cli-arguments ** [x] `--price.db-path` ** [x] `--price.lookup-type` ** [x] `--price.before` ** [ ] `--report.commodity` * [ ] tackler.toml ** [x] `price.db-path` ** [x] `price.lookup-type` ** [ ] `report.commodity` Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
* [x] cli-arguments ** [x] `--price.db-path` ** [x] `--price.lookup-type` ** [x] `--price.before` ** [x ] `--report.commodity` * [x] tackler.toml ** [x] `price.db-path` ** [x] `price.lookup-type` ** [x] `report.commodity` Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
WIP: Register report is still not correct Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
This has no real impact either way, but be more consistent in style. Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
WIP: The commodity metadata is still missing,
and some formatting is off.
#36
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Push price related configuration to Settings. Refactor report settings to kernel-level module, next to the settings. Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
[skip ci] Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Don't cache commodities when there isn't conversion available. Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
#36 Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This TEP-1015 adds Price data support to Tackler
Thank you @RagibHasin for the idea of historic price data analysis and contributing ideas, discussion and code for actual implementation. This contribution is very much appreciated - thank you!
closes GH-36