Feature: Template build details page #204
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Removed `clientSegmentCache` from Next.js configuration. - Updated `StatusBanner` in `BuildHeader` to use dynamic status and message from `buildDetails`. - Added new imports for additional table cells in the builds table component. - Enhanced `formatDurationCompact` function to improve decimal second formatting. - Modified `getBuildInfo` query to include `team_id` in the selection and filtering. These changes improve the clarity and functionality of the dashboard components and enhance data handling in the builds repository.
src/app/dashboard/[teamIdOrSlug]/templates/[templateId]/builds/[buildId]/page.tsx
Show resolved
Hide resolved
| code: 'NOT_FOUND', | ||
| message: "Build not found or you don't have access to it", | ||
| }) | ||
| } |
There was a problem hiding this comment.
Bug: Database errors incorrectly reported as NOT_FOUND
The getBuildInfo function throws a NOT_FOUND TRPCError for any Supabase error, including network failures, database errors, and permission issues. This masks real errors as 404s, making debugging difficult and showing users misleading "not found" messages when there are actual server problems. The other functions in this file (getInfraBuildStatus, getInfraBuildLogs) correctly differentiate 404 errors from other errors using apiError(status) for non-404 cases, but getBuildInfo lacks this distinction.
ben-fornefeld
deleted the
implement-template-build-details-page-eng-3335
branch
Note
Adds a new template build details page with live, filterable logs and status; updates API spec and server to fetch build info/logs; improves layout/breadcrumbs and links from builds table; enables React Query Devtools.
dashboard/[team]/templates/[template]/builds/[build]with header (status, timings, template link) and virtualized, filterable logs (back/forward pagination, auto-scroll).CopyButtonInline,DetailsRow/DetailsItem,loadingre-export for the build page.TitleSegment; config now functions per-path; sidebar active match widened; addedPROTECTED_URLS.TEMPLATE_BUILD.buildDetails,buildLogsBackwards,buildLogsForwardusing infra client; build DTOs for details/logs; retention check; mapping helpers.LogsDirection,LogsSource,TemplateBuildLogsResponse), template/build models,MachineInfo,SandboxNetworkConfig,Mcp.POST /sandboxes/{id}/connect,GET /templates/{id}(with builds),GET /templates/{id}/builds/{id}/logs,POST /v3/templates; marked several legacy endpoints deprecated.infra-api.typesupdated accordingly;types/api.typesnarrowsTemplatefields.useTRPCClient; enable@tanstack/react-query-devtools.formatDurationCompactsupports decimal seconds.DetailsRow.Written by Cursor Bugbot for commit 1c4739e. This will update automatically on new commits. Configure here.