[WIP] Fix issues with error checks #1322
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Standardizes error handling across API, orchestrator, and proxy by replacing type assertions with errors.As/Is and introducing sentinel errors; updates related tests.
errors.As
/errors.Is
inpackages/api/internal/handlers/*
,orchestrator/*
, and sandbox block code.ErrNoAuthHeader
now a sentinel (errors.New
).InvalidHostError
/InvalidSandboxPortError
types with sentinel vars and useerrors.Is
inhandler.go
andhost.go
.sandbox_kill.go
: handledb.EnvNotFoundError
viaerrors.As
.template_build_status.go
: handledb.TemplateBuildNotFoundError
viaerrors.As
.pause_instance.go
: detectPauseQueueExhaustedError
viaerrors.As
.ReleaseDeviceWithRetry
retries onDeviceInUseError
viaerrors.As
.chunk.go
andoverlay.go
useerrors.As
forBytesNotAvailableError
.require.ErrorAs
forLimitExceededError
andAlreadyBeingStartedError
.Written by Cursor Bugbot for commit 48ebf17. This will update automatically on new commits. Configure here.