Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/bidirectional #628

Merged
merged 16 commits into from
Nov 7, 2024

Conversation

SimonRubenDrauz
Copy link
Collaborator

some bugfixes

# Conflicts:
#	src/pandapipes/pf/derivative_calculation.py
#	src/pandapipes/pipeflow.py
… into bugfix/bidirectional

# Conflicts:
#	src/pandapipes/component_models/abstract_models/circulation_pump.py
#	src/pandapipes/idx_branch.py
… into bugfix/bidirectional

# Conflicts:
#	src/pandapipes/pipeflow.py
- adapt wrong input in press control
- set heat consumer with q_ext = 0 out of service if mdot is not defined
- if there is only on node left, the pipeflow should still converge
@SimonRubenDrauz SimonRubenDrauz merged commit 5d182b7 into e2nIEE:develop Nov 7, 2024
28 of 29 checks passed
@SimonRubenDrauz SimonRubenDrauz deleted the bugfix/bidirectional branch November 7, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants