Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive changes for HttpManager #205

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Adaptive changes for HttpManager #205

merged 3 commits into from
Sep 4, 2024

Conversation

yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Aug 30, 2024

Relevant changes: eBay/IOManager#100

@yuwmao yuwmao requested a review from raakella1 August 30, 2024 13:12
@xiaoxichen
Copy link
Contributor

seem like you forgot the change on conanfile.py

Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this

ioenvironment.restart_http_server();

This will restart http server and pass empty value for certs. We should only start http server once in SM. This restart should be removed

@yuwmao
Copy link
Contributor Author

yuwmao commented Aug 31, 2024

Can you fix this

ioenvironment.restart_http_server();

This will restart http server and pass empty value for certs. We should only start http server once in SM. This restart should be removed

Sure.

@yuwmao
Copy link
Contributor Author

yuwmao commented Aug 31, 2024

seem like you forgot the change on conanfile.py

Yes, changed.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (acb04e8) to head (e2dddb7).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_http_manager.cpp 40.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   68.69%   70.13%   +1.44%     
==========================================
  Files          30       30              
  Lines        1581     1537      -44     
  Branches      163      160       -3     
==========================================
- Hits         1086     1078       -8     
+ Misses        408      370      -38     
- Partials       87       89       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoxichen xiaoxichen merged commit c6c4c27 into eBay:main Sep 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants