feat(chips-combobox): add component #2062
Conversation
| interface ChipsComboboxInput extends Omit<Marko.Input<"input">, `on${string}`> { | ||
| expanded?: boolean; | ||
| fluid?: boolean; | ||
| error?: boolean; | ||
| "list-selection"?: "manual" | "automatic"; | ||
| options: string[]; | ||
| selected?: string[]; | ||
| roledescription?: AttrString; | ||
| "a11y-delete-button"?: AttrString; | ||
| "on-expand"?: () => void; | ||
| "on-collapse"?: () => void; | ||
| "on-change"?: (event: ChipsComboboxEvent) => void; | ||
| } |
There was a problem hiding this comment.
Lets put this in index.marko like we had discussed with Dylan.
| </ul> | ||
| </if> | ||
| <ebay-combobox | ||
| class=["chips-combobox__combobox", inputClass] |
There was a problem hiding this comment.
Generally we want to put the extra classes on the root. The reason is sometimes users might want to be able to use those classes as selectors.
| @@ -9,8 +9,8 @@ | |||
| "compilerOptions": { | |||
| "allowSyntheticDefaultImports": true, | |||
| "incremental": true, | |||
| "lib": ["dom"], | |||
| "module": "commonjs", | |||
| "lib": ["dom", "ESNext"], | |||
There was a problem hiding this comment.
Lets push this change directly to master or to 13.1.0. Lets not have it part of this PR
There was a problem hiding this comment.
Nice work! The code itself looks good.
There appear to be a11y violations. Some, for example, the first two about forms may not be legitimate, but others likely are.
@ianmcburnie, @saiponnada , thoughts?
Maybe we missed a couple of these in Skin?
For isolated view this should be fine |
Description
chips-comboboxcomponentchipsandcombobox, but none are breakingScreenshots