Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.1.0 #1

Merged
merged 80 commits into from
Oct 9, 2024
Merged

v0.1.0 #1

merged 80 commits into from
Oct 9, 2024

Conversation

unabris
Copy link
Member

@unabris unabris commented Oct 4, 2024

No description provided.

@unabris
Install, configure and fix rubocop
50c2564
@unabris
Remove unnecessary files
c96c715
@unabris
Install and configure rspec
2a5dda5
@unabris
Add component SVGs
d4ffaa9
@unabris
Add some components
f51f9fa
@unabris
Update rspec output
bf704e5
@unabris
Update dependencies
d057f6d
@unabris
Update gemspec
8140abf
@unabris
Update to use sassc-rails
8d4b996
@unabris
Add missing styles
0d5e3da
@unabris
Add tests
353b578
@unabris
Add simple_form configuration
6745049
@unabris
Fix rubocop
fa2d80c
@unabris
Add button and link components
d66c398
@unabris
Move images
b8900b8
@unabris
Move action bar to component
37d0158
@unabris
Fix rubocop
0537c07
@unabris
Add basic test page
e18d4c6
@unabris
Dependency update
b95a06f
@unabris
Add conditional rendering
0d454b0
@unabris
Remove unnecessary file
8c41fbc
@unabris
Update body rendering
1b5e59e
@unabris
Remove unnecessary layout
e4c66d5
@unabris
Add fetch_or_fallback methods
b564f7f
@unabris
Remove turbo-rails dependency
9723c11
@unabris
Autoload lib directory
95c7e83
@unabris
Refactor file retrieval
b62a537
@unabris
Rename attribute
70dd897
@unabris
Add dummy content
5644226
@unabris
Make default js controllers work
1d57c30
kengallego
kengallego reviewed Oct 7, 2024
View reviewed changes
@unabris
Copy link
Member Author

unabris commented Oct 7, 2024

@k4th, @kengallego, texts for CONTRIBUTING.md were taken and some parts removed from https://github.com/thoughtbot/factory_bot/blob/main/CONTRIBUTING.md. Do you still want to adapt it? I'm fine but wanted to double check with you.

@kengallego
Copy link

kengallego commented Oct 7, 2024 •
edited
Loading

@k4th, @kengallego, texts for CONTRIBUTING.md were taken and some parts removed from https://github.com/thoughtbot/factory_bot/blob/main/CONTRIBUTING.md. Do you still want to adapt it? I'm fine but wanted to double check with you.

Overall I see it better having these changes, some of them are just a refactor but some other like the steps i wrote (although many people will not read it) people that are beginners will have a clearer path to follow

@k4th
Copy link

k4th commented Oct 7, 2024

@k4th, @kengallego, texts for CONTRIBUTING.md were taken and some parts removed from https://github.com/thoughtbot/factory_bot/blob/main/CONTRIBUTING.md. Do you still want to adapt it? I'm fine but wanted to double check with you.

It's fine how it is right now.

@unabris unabris merged commit 09f6858 into main Oct 9, 2024
4 checks passed
@unabris unabris deleted the v0.1.0 branch October 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kengallego kengallego kengallego left review comments

@k4th k4th k4th approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unabris @kengallego @k4th