Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump got from 12.5.3 to 13.0.0 #296

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 29, 2023

Bumps got from 12.5.3 to 13.0.0.

Release notes

Sourced from got's releases.

v13.0.0

As a reminder, Got continues to require ESM. For TypeScript users, this includes having "module": "node16", "moduleResolution": "node16" in your tsconfig.

Breaking

  • Require Node.js 16 52a1063
  • Change the enableUnixSockets option to be false by default 852c312
    • Most users don't need it.

Improvements

  • Allow specifying undefined for options (#2258) 1cefe8b

sindresorhus/got@v12.6.1...v13.0.0

v12.6.1

  • Fix get-stream import statement (#2266) 67d5039

sindresorhus/got@v12.6.0...v12.6.1

v12.6.0

  • Update dependencies 88c88fb 979272e
  • Loosen URL validation strictness (#2200) 0ca0b7f

sindresorhus/got@v12.5.3...v12.6.0

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 29, 2023
@line-o
Copy link
Member

line-o commented Oct 18, 2023

@dependabot rebase

Bumps [got](https://github.com/sindresorhus/got) from 12.5.3 to 13.0.0.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](sindresorhus/got@v12.5.3...v13.0.0)

---
updated-dependencies:
- dependency-name: got
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/got-13.0.0 branch from 5bd4e6d to bd43cb1 Compare October 18, 2023 11:42
@line-o
Copy link
Member

line-o commented Oct 18, 2023

This is a breaking change as we would need to raise the minimum node version to 16 (which is no longer visible in our testmatrix ... )

@line-o line-o requested a review from a team October 18, 2023 12:07
@duncdrum
Copy link
Contributor

I m ok with breaking change with min version 16

@line-o
Copy link
Member

line-o commented Oct 18, 2023

Me too. It is just important to not merge this PR as is but do the necessary changes in package.json and to modify the commit message (add a !)

Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to signal a breaking change and to include the change of the engine requirements in package.json

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 30, 2023

Superseded by #323.

@dependabot dependabot bot closed this Nov 30, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/got-13.0.0 branch November 30, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants