Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align connection options and allow override of protocol from env #305

Merged
merged 3 commits into from
Oct 21, 2023
Merged

align connection options and allow override of protocol from env #305

merged 3 commits into from
Oct 21, 2023

Commits on Oct 18, 2023

  1. fix(connection): readOptionsFromEnv sets protocol 

    This is needed to allow REST connections using
`http:` to override the default (`https:`).
    @line-o
    line-o committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    a7076a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. feat(connection): align connection options 

    Both REST and XML-RPC now have the same set of default options.
The boolean option `secure` can still be used
to control XMLRPC client, but `protocol` is the preferred way.
This allows to use the same set of options for both client constructors.

Add test to ensure legacy option is still working.
    @line-o
    line-o committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6ebed79 View commit details
    Browse the repository at this point in the history

  2. doc(readme): clarify REST, connection and more 

    - fix TOC
- rename and improve Configuration section to Connection Options
- clarify wording in Use - REST
- clarify that Components is using XML-RPC
    @line-o
    line-o committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d9c9e80 View commit details
    Browse the repository at this point in the history