Error when checking out invalid snapshot ID

[dcherian]

Closes #235

ValueError: store error: unsuccessful repository operation: `snapshot not found: `F000BARSPAM123456780``

[rabernat]

Could we get more colons into the error message please? 😆

[paraseba]

nitpicking: I think Storage is enough here? No need for Send + Sync?

[dcherian]

apparently required:

error[E0277]: `dyn icechunk::Storage` cannot be shared between threads safely
    --> icechunk-python/src/lib.rs:364:9
     |
364  | /         pyo3_asyncio_0_21::tokio::future_into_py(py, async move {
365  | |             do_checkout_snapshot(store, snapshot_id).await
366  | |         })
     | |__________^ `dyn icechunk::Storage` cannot be shared between threads safely
     |
     = help: the trait `std::marker::Sync` is not implemented for `dyn icechunk::Storage`, which is required by `{async block@icechunk-python/src/lib.rs:364:54: 364:64}: std::marker::Send`
     = note: required for `&dyn icechunk::Storage` to implement `std::marker::Send`
note: required because it's used within this `async` fn body

[paraseba]

But, I don't get it. It errors in an unrelated function we are not calling?

[dcherian]

This function does end up calling our new function to make sure snapshot_id is valid during hceckout, is that it?