-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when checking out invalid snapshot ID #317
Conversation
Could we get more colons into the error message please? 😆 |
@@ -1112,6 +1114,17 @@ async fn all_chunks<'a>( | |||
Ok(existing_array_chunks.chain(new_array_chunks)) | |||
} | |||
|
|||
pub async fn raise_if_invalid_snapshot_id( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking: I think Storage is enough here? No need for Send + Sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently required:
error[E0277]: `dyn icechunk::Storage` cannot be shared between threads safely
--> icechunk-python/src/lib.rs:364:9
|
364 | / pyo3_asyncio_0_21::tokio::future_into_py(py, async move {
365 | | do_checkout_snapshot(store, snapshot_id).await
366 | | })
| |__________^ `dyn icechunk::Storage` cannot be shared between threads safely
|
= help: the trait `std::marker::Sync` is not implemented for `dyn icechunk::Storage`, which is required by `{async block@icechunk-python/src/lib.rs:364:54: 364:64}: std::marker::Send`
= note: required for `&dyn icechunk::Storage` to implement `std::marker::Send`
note: required because it's used within this `async` fn body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, I don't get it. It errors in an unrelated function we are not calling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function does end up calling our new function to make sure snapshot_id is valid during hceckout, is that it?
This reverts commit 30ad102.
Closes #235