Skip to content

Fix community calendar showing incorrect times during DST#1255

Open
mfisher87 wants to merge 2 commits intomainfrom
fix-calendar-tz
Open

Fix community calendar showing incorrect times during DST#1255
mfisher87 wants to merge 2 commits intomainfrom
fix-calendar-tz

Conversation

@mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Mar 6, 2026

Description

Currently, the embedded calendar screws up at DST boundary and shows the wrong time. The calendar is set up so events are scheduled in MST, but the embedded calendar is disrespecting the setting. Weirder, viewing the calendar outside of an iframe context by opening the iframe's src in a new tab does not reproduce this issue.

Is the solution to embed the calendar's TZ in the URL? I don't know. Let's find out :)

Tests:

  • Time doesn't change after DST boundary
  • Folks outside of MST see the correct time (e.g. 10AM PST)

"Ready for review" checklist

  • Open PR as draft
  • Please review our Pull Request Guide
  • Mark "ready for review" after following instructions in the guide

Merge checklist

  • PR title is descriptive
  • PR body contains links to related and resolved issues (e.g. closes #1)
  • If needed, CHANGELOG.md updated
  • If needed, docs and/or README.md updated
  • If needed, unit tests added
  • All checks passing (comment pre-commit.ci autofix if pre-commit is failing)
  • At least one approval

📚 Documentation preview 📚: https://earthaccess--1255.org.readthedocs.build/en/1255/

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Binder 👈 Launch a binder notebook on this branch for commit b83345e

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 6c665e5

@mfisher87 mfisher87 changed the title Add timezone to calendar embed URL Fix community calendar showing incorrect times during DST Mar 6, 2026
@mfisher87
Copy link
Member Author

Test failure not caused by this PR, resolved in #1256

@mfisher87
Copy link
Member Author

mfisher87 commented Mar 6, 2026

Calling non-Mountain Time folks to test it out! @jhkennedy ? @jules32 ? I know there are more, my brain isn't cooperating though :)

Do you see the meeting at the correct time for your time zone, or do you see 11AM?

https://earthaccess--1255.org.readthedocs.build/en/1255/calendar/

@jhkennedy
Copy link
Contributor

On the docs page it still appears as Mt time to me:
image

@mfisher87
Copy link
Member Author

That's exactly what I was worried about :(

@mfisher87
Copy link
Member Author

@jhkennedy Just want to be sure, when you view the calendar here (https://earthaccess.readthedocs.io/en/latest/calendar/) it shows in your local time, right?

@chuckwondo
Copy link
Contributor

Just want to be sure, when you view the calendar here (https://earthaccess.readthedocs.io/en/latest/calendar/) it shows in your local time, right?

It shows my local time.

@jhkennedy
Copy link
Contributor

The calendar at both of these links look identical to me:

image

I would expect to see GMT-09 for my local timezone

@mfisher87
Copy link
Member Author

And for @jhkennedy neither of those calendars shows the weird DST thing we were seeing. Wat

@chuckwondo at https://earthaccess--1255.org.readthedocs.build/en/1255/calendar/ do you see local time as well?

@chuckwondo
Copy link
Contributor

The calendar at both of these links look identical to me:

Huh. The first links shows my local time, but the second shows MT.

@mfisher87
Copy link
Member Author

mfisher87 commented Mar 6, 2026

The calendar at both of these links look identical to me:

Huh. The first links shows my local time, but the second shows MT.

OK this is what I expected and what I was worried about. I'm not sure how to fix this. Maybe the solution is wait until we cross the DST boundary and see if this fixes itself. At least we don't have to wait long!

What @jhkennedy is seeing is NOT expected. The live site should show local time like Chuck is seeing. This is frustrating.

@mfisher87
Copy link
Member Author

mfisher87 commented Mar 6, 2026

This is even more confusing. On the GeoJupyter calendar (https://geojupyter.org/calendar) I see the same behavior, but only for some events??? On the 10th one event is shifted forward by an hour while the other event is unshifted. All events on Wednesdays are unimpacted. The event that was shifted forward by an hour on the 10th goes back to normal on the 31st. WAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants