Fix community calendar showing incorrect times during DST#1255
Fix community calendar showing incorrect times during DST#1255
Conversation
|
Test failure not caused by this PR, resolved in #1256 |
|
Calling non-Mountain Time folks to test it out! @jhkennedy ? @jules32 ? I know there are more, my brain isn't cooperating though :) Do you see the meeting at the correct time for your time zone, or do you see 11AM? https://earthaccess--1255.org.readthedocs.build/en/1255/calendar/ |
|
That's exactly what I was worried about :( |
|
@jhkennedy Just want to be sure, when you view the calendar here (https://earthaccess.readthedocs.io/en/latest/calendar/) it shows in your local time, right? |
It shows my local time. |
|
The calendar at both of these links look identical to me:
I would expect to see GMT-09 for my local timezone |
|
And for @jhkennedy neither of those calendars shows the weird DST thing we were seeing. Wat @chuckwondo at https://earthaccess--1255.org.readthedocs.build/en/1255/calendar/ do you see local time as well? |
Huh. The first links shows my local time, but the second shows MT. |
OK this is what I expected and what I was worried about. I'm not sure how to fix this. Maybe the solution is wait until we cross the DST boundary and see if this fixes itself. At least we don't have to wait long! What @jhkennedy is seeing is NOT expected. The live site should show local time like Chuck is seeing. This is frustrating. |
|
This is even more confusing. On the GeoJupyter calendar (https://geojupyter.org/calendar) I see the same behavior, but only for some events??? On the 10th one event is shifted forward by an hour while the other event is unshifted. All events on Wednesdays are unimpacted. The event that was shifted forward by an hour on the 10th goes back to normal on the 31st. WAT. |


Description
Currently, the embedded calendar screws up at DST boundary and shows the wrong time. The calendar is set up so events are scheduled in MST, but the embedded calendar is disrespecting the setting. Weirder, viewing the calendar outside of an iframe context by opening the iframe's
srcin a new tab does not reproduce this issue.Is the solution to embed the calendar's TZ in the URL? I don't know. Let's find out :)
Tests:
"Ready for review" checklist
Merge checklist
closes #1)CHANGELOG.mdupdatedREADME.mdupdatedpre-commit.ci autofixif pre-commit is failing)📚 Documentation preview 📚: https://earthaccess--1255.org.readthedocs.build/en/1255/