test unknown items type

earthastronaut · Aug 20, 2021 · 024e8f4 · 024e8f4
1 parent 5562bcd
commit 024e8f4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/classyjson.py b/classyjson.py
@@ -571,6 +571,8 @@ def get_jsonschema(self) -> TJson:
             schema["items"] = items.get_jsonschema()
         elif isinstance(items, type) and issubclass(items, ClassyJson):
             schema["items"] = items.schema.get_jsonschema()
+        elif isinstance(items, dict):
+            schema["items"] = items.copy()
         elif isinstance(items, list):
             items_schema = []
             for item in items:
@@ -581,8 +583,8 @@ def get_jsonschema(self) -> TJson:
                 else:
                     items_schema.append(dict(item))
             schema["items"] = items_schema
-        elif items is not None:
-            schema["items"] = items
+        else:
+            raise TypeError(f"Unknown type {type(items)}")
         return schema
 
     def load(self, instance: TJson, validate: bool = True) -> Any:

diff --git a/tests/test_schema.py b/tests/test_schema.py
@@ -152,6 +152,15 @@ def test_array_items_list(self):
         }
         self.assertEqual(actual, expected)
 
+    def test_array_items_get_schema_unknown(self):
+        schema = ArraySchema(
+            items=2,
+        )
+        self.assertRaises(
+            TypeError,
+            schema.get_jsonschema,
+        )
+
 
 class TestSchemaLoad(unittest.TestCase):
     def _get_example_1(self):