bugfix: exportPath null when no use of eotdl dataset#48
Open
LuisPalluel wants to merge 1 commit intoearthpulse:mainfrom
Open
bugfix: exportPath null when no use of eotdl dataset#48LuisPalluel wants to merge 1 commit intoearthpulse:mainfrom
LuisPalluel wants to merge 1 commit intoearthpulse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was testing Scaneo with my own data.
After labelling my campaign, I tried to export the labels but an error happened.
After searching in the code, it appears that the exportPath variable was null when trying to export.
This variable is set when "campaigns.current?.eotdlDatasetId" in the form but not otherwise.
So I made a small change by checking if the campaign has a path and no exportPath is set, then I create the exportPath to "{campaignPath}/labels".
Feel free to use or not.
I'm not used to pull request thus sorry if the shape of my PR is not appropriate.