Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doctrine/annotations to dependencies (#58) #59

Closed

Conversation

mbaschnitzi
Copy link

Version 3.30.0 of jms/serializer dropped doctrine/annotations from its dependencies, so it needs to be directly required.

This pull request fixes #58 via requiring doctrine/annotations explicitly.

An alternative would be to convert all annotations to attributes and bump the minimum php version to 8.0. If it is preferred I can make those changes instead.

Version 3.30.0 of jms/serializer dropped doctrine/annotations from its
dependencies, so it needs to be directly required.
@BolZer
Copy link
Member

BolZer commented Mar 11, 2024

This issue is done with #60. Gonna close this PR.

@BolZer BolZer closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency doctrine/annotations since jms/serializer:3.30.0
2 participants