Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce #3472 (transfer Bundle requirements to module) but do not create logfile in components #3509

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Thyre
Copy link
Contributor

@Thyre Thyre commented Nov 15, 2024

This fixes the increased disk usage when running the EasyConfig test suite as log files would stay open.
See easybuilders/easybuild-easyconfigs#21841 for more information.

Requires:

Related:

See #3472 for the initial review and #3504 for the occurring issue, causing a revert of the PR.

Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
This fixes the increased memory usage when running the EasyConfig test suite
as log files would stay open.

Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
@Thyre
Copy link
Contributor Author

Thyre commented Nov 15, 2024

Test report by @Thyre

Overview of tested easyconfigs (in order)

  • SUCCESS GCC-13.3.0.eb
  • SUCCESS Autotools-20231222-GCCcore-13.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
Linux - Linux EndeavourOS UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 565.57.01, Python 3.12.7
See https://gist.github.com/Thyre/91835076bbb9bad8921c1b8608402863 for a full test report.

@Thyre Thyre changed the title Reintroduce #3472 (transfer Bundle requirements to module), but do not transfer logfile Reintroduce #3472 (transfer Bundle requirements to module) but do not create logfile in components Nov 15, 2024
@Thyre Thyre marked this pull request as ready for review November 15, 2024 08:45
@Thyre
Copy link
Contributor Author

Thyre commented Nov 15, 2024

Test report by @Thyre

Overview of tested easyconfigs (in order)

Build succeeded for 9 out of 19 (10 easyconfigs in total)
datenlager - Linux Ubuntu 24.04, x86_64, AMD Ryzen 7 3700X 8-Core Processor, Python 3.12.3
See https://gist.github.com/Thyre/1f2efb9ca0b89f91030fc316828e19d2 for a full test report.

@Thyre
Copy link
Contributor Author

Thyre commented Nov 15, 2024

Test report by @Thyre

Overview of tested easyconfigs (in order)

[...]

Build succeeded for 9 out of 19 (10 easyconfigs in total) datenlager - Linux Ubuntu 24.04, x86_64, AMD Ryzen 7 3700X 8-Core Processor, Python 3.12.3 See https://gist.github.com/Thyre/1f2efb9ca0b89f91030fc316828e19d2 for a full test report.

Failures due to #3402 missing.

== 2024-11-15 09:07:43,949 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/tools/build_log.py:111 in caller_info): No viable license specifications found; specify 'license_file', or define $INTEL_LICENSE_FILE or $LM_LICENSE_FILE (at easybuild/easyblocks/generic/intelbase.py:308 in prepare_step)

Comment on lines -324 to -325
# close log for this component
comp.close_log()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure that this removal is safe. Based on the changes in framework I think it is, as the components just use the log file of the Bundle. Keeping it in doesn't hurt though, as the changes in framework should make sure that only Bundle can close its log and none of the components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants