add support for multiple modulenames in extensions #4716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the allowed types of the `modulename` extension option: - `False` to skip the sanity check and always install it when `--skip` is used - `str`: Value for `%(ext_name)s` in the `exts_filter` template - List of `str`: Multiple names to be used in the `exts_filter` template. All resulting commands must succeed. It replaces `resolve_exts_filter_template` by `construct_exts_filter_cmds` as the method now returns a, potentially empty, list which might cause errors if used without expecting a list.
There shouldn't be a command executed for that.
This might be useful for easyblocks to avoid duplicating the code for determining the modulename from either the options or the name.
Flamefire
force-pushed
the
multiple-modulenames
branch
from
bd305b1 to
7dac45e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the allowed types of the
modulenameextension option:Falseto skip the sanity check and always install it when--skipis usedstr: Value for%(ext_name)sin theexts_filtertemplatestr: Multiple names to be used in theexts_filtertemplate. All resulting commands must succeed.This was previously suggested to allow Perl modules that are part of other Perl modules and hence don't need to be installed multiple times. See easybuilders/easybuild-easyconfigs#12575
It replaces
resolve_exts_filter_templatebyconstruct_exts_filter_cmdsas the method now returns a, potentially empty, list which might cause errors if used without expecting a list.The function is only used internally in framework and not by any easyblocks.