fix create_source_tarball.sh script to be compatible with recent setuptools versions
#894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
commented
Jun 12, 2024
| @@ -22,7 +22,7 @@ function success() { | |||
| } | |||
|
|
|||
| function warning() { | |||
| echo -e "\033[31mWARNING: $1\033[0m" >&2 | |||
| echo -e "\033[33mWARNING: $1\033[0m" >&2 | |||
There was a problem hiding this comment.
This just makes warnings yellow rather than red, so they stand out from errors a bit better
…ptools versions which 'normalize' package names by replacing dashes with underscores
boegel
force-pushed
the
fix_create_source_tarball_script
branch
from
ae1b1ad
to
2050249
Compare
boegel
force-pushed
the
fix_create_source_tarball_script
branch
from
0b83f26
to
738a6af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of setuptools (>= 69.0.3, not sure?) 'normalize' package names by replacing dashes with underscores, so we source tarballs like
easybuild_framework-4.9.2.tar.gzinstead ofeasybuild-framework-4.9.2.tar.gz.The changes being made here accept both, just to stay compatible with older setuptools versions (or in case they change their mind again...)
edit: see also easybuilders/easybuild-easyblocks#3358