fix and de-lint

easystats · Feb 6, 2024 · df3fcb7 · df3fcb7
1 parent 85dbf30
commit df3fcb7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/R/bayesfactor_restricted.R b/R/bayesfactor_restricted.R
@@ -137,7 +137,7 @@ bayesfactor_restricted.stanreg <- function(posterior, hypothesis, prior = NULL,
 
   samps <- .clean_priors_and_posteriors(posterior, prior,
     effects = effects, component = component,
-    parameters = parameters, verbose = verbose
+    verbose = verbose
   )
 
   # Get savage-dickey BFs
@@ -217,7 +217,7 @@ bayesfactor_restricted.data.frame <- function(posterior, hypothesis, prior = NUL
 
   posterior_l <- as.data.frame(lapply(p_hypothesis, .test_hypothesis, data = posterior))
   prior_l <- as.data.frame(lapply(p_hypothesis, .test_hypothesis, data = prior))
-  colnames(posterior_l) <- colnames(prior_l) <- if (!is.null(names(hypothesis))) names(hypothesis) else hypothesis
+  colnames(posterior_l) <- colnames(prior_l) <- if (is.null(names(hypothesis))) hypothesis else names(hypothesis)
 
   posterior_p <- sapply(posterior_l, mean)
   prior_p <- sapply(prior_l, mean)

diff --git a/R/utils_bayesfactor.R b/R/utils_bayesfactor.R
@@ -190,11 +190,10 @@
 
   # Prior and post odds
   Modelnames <- BFGrid$Model
-  if (!is.null(priorOdds)) {
-    priorOdds <- c(1, priorOdds)
-  } else {
-    priorOdds <- rep(1, length(Modelnames))
+  if (is.null(priorOdds)) {
+    priorOdds <- rep(1, length(Modelnames) - 1)
   }
+  priorOdds <- c(1, priorOdds)
 
   prior_logodds <- log(priorOdds)
   posterior_logodds <- prior_logodds + BFGrid$log_BF