Deal with lnr models #1041
Merged
Deal with lnr models #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -945,7 +946,7 @@ get_predicted.phylolm <- function(x, | |||
| stringsAsFactors = FALSE | |||
| ) | |||
| # make sure we have the correct name for the "Response column" | |||
| if (is_wiener) { | |||
| if (is_wiener || is_lnr) { | |||
There was a problem hiding this comment.
I think we could have something more generic than is_lnr, like is_ssm ("sequential sampling models", the official name of decision making models)
There was a problem hiding this comment.
Ok, so this would also identify your other custom models? Which would you prefer, are all models about reaction time and discrete choices?
There was a problem hiding this comment.
We could also change is_wiener to the general name
| @@ -419,6 +420,7 @@ | |||
| is_ftest = is_ftest, | |||
| is_meta = is_meta, | |||
| is_wiener = inherits(x, "brmsfit") && fitfam == "wiener", | |||
| is_lnr = inherits(x, "brmsfit") && fitfam == "custom" && identical(brms_custom_name, "lnr"), | |||
There was a problem hiding this comment.
here we can have is_rtchoice, and we will check for various models (LNR, LBA, ...) that will all behave the same (by having even-odd iterations)
Wiener behaves differently (negative RTs) so we need to deal separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.