Added support for mgcv::gaulss
for find_formula
and find_variables
#841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #840
Added support for
mgcv::gaulss
infind_formula
andfind_variables
.For
R/find_formula.R/find_formula.gam
, i'm pretty sure theis.null
is supposed to be outside of the ifmi$familly == x
checks. Other than that, just a straight forward case of checking if the family is "gaulss" and if yes then extract not only the conditional variables for the location parameter but also the variables for the scale parameter.For
R/find_variables.R/find_variables
, have to update the choices to also have "scale".Added tests for this change. Sorry if there are any mistakes, this is my first PR ever