Skip to content

Commit

Permalink
Don't subst the values on dye_item_select_dlg::load. Update to v2.28
Browse files Browse the repository at this point in the history
  • Loading branch information
ebengoechea committed Feb 28, 2024
1 parent c971a47 commit f3fba3b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 2 additions & 2 deletions DYE.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ try {
namespace eval ::plugins::DYE {
variable author "Enrique Bengoechea"
variable contact "enri.bengoechea@gmail.com"
variable version 2.44
variable version 2.45
variable github_repo ebengoechea/de1app_plugin_DYE
variable name [translate "Describe Your Espresso"]
variable description [translate "Describe any shot from your history and plan the next one: beans, grinder, extraction parameters and people. Also includes beans-based workflow, shot history management, and profile tools."]
Expand Down Expand Up @@ -7284,7 +7284,7 @@ namespace eval ::dui::pages::dye_item_select_dlg {

# If no selected is given, but variable is given and it has a current value, use it as selected.
set data(variable) $variable
set data(item_values) [subst $values]
set data(item_values) $values
set data(item_ids) [::dui::args::get_option -values_ids {}]
if { $data(item_ids) ne {} && [llength $data(item_values)] != [llength $data(item_ids)] } {
msg -ERROR [namespace current] "load: item_ids and item_values have different lengths"
Expand Down
5 changes: 5 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Format based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [2.45] - 2024-02-28

### Changed
- Fixed a bug that was tcl-subst'ing values passed to dialog ``dye_item_select_dlg`` so they would fail if they had characters interpretable by Tcl. Reported by Omer Ytzhaki.

## [2.44] - 2024-02-23

### Changed
Expand Down

0 comments on commit f3fba3b

Please sign in to comment.