Disable auto-scroll

ebigram · Mar 17, 2019 · 84799e6 · 84799e6
1 parent 2543dfb
commit 84799e6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/src/scroller.js b/src/scroller.js
@@ -120,13 +120,14 @@ export default function Scroller({
     });
   }, []);
 
-  React.useLayoutEffect(() => {
-    dispatch({
-      type: "change-area",
-      recalculate: true,
-      changeIndex: closestIndex
-    });
-  }, [snapAreas]);
+  // Auto-scroll to closest change when changing versions:
+  // React.useLayoutEffect(() => {
+  //   dispatch({
+  //     type: "change-area",
+  //     recalculate: true,
+  //     changeIndex: closestIndex
+  //   });
+  // }, [snapAreas]);
 
   React.useLayoutEffect(() => {
     if (snap) {

diff --git a/src/scroller.story.js b/src/scroller.story.js
@@ -12,7 +12,8 @@ const snapAreas1 = [
 const snapAreas2 = [
   { start: 8, end: 12 },
   { start: 30, end: 32 },
-  { start: 550, end: 552 }
+  { start: 550, end: 552 },
+  { start: 595, end: 599 }
 ];
 
 const items = Array(600)

diff --git a/src/utils.js b/src/utils.js
@@ -19,7 +19,8 @@ export function getScrollTop(area, contentHeight, containerHeight, heights) {
   const bestTop =
     end - start > containerHeight ? start : middle - halfContainer;
   if (bestTop < 0) return 0;
-  if (bestTop + containerHeight > contentHeight)
-    return containerHeight - contentHeight;
+  if (bestTop + containerHeight > contentHeight) {
+    return contentHeight - containerHeight;
+  }
   return bestTop;
 }