fix(grades): format null grades to 0

eclass · Aug 19, 2024 · f05ca0e · f05ca0e
1 parent e1c6bac
commit f05ca0e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -4,6 +4,6 @@
   "javascript.implicitProjectConfig.checkJs": true,
   "javascript.validate.enable": true,
   "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": true
+    "source.fixAll.eslint": "explicit"
   }
 }
diff --git a/lib/grades/gradeFormat.ts b/lib/grades/gradeFormat.ts
@@ -8,6 +8,9 @@ Agrega puntos, comas, caracteres antes o despues de la nota.
  * @example const formated = gradeFormat(scale, grade)
  */
 export const gradeFormat = (scale: ScaleAttributes, grade: number): string => {
+  if (grade === null) {
+    grade = 0
+  }
   let round = `${gradeRound(scale, grade)}`
 
   if (round.length === 1 && scale.append === '' && scale.base !== 'Peru') {

diff --git a/lib/grades/gradeRound.ts b/lib/grades/gradeRound.ts
@@ -8,6 +8,9 @@ import { ScaleAttributes } from '../types'
 export const gradeRound = (scale: ScaleAttributes, grade: number): number => {
   try {
     let rounded: number | string
+    if (grade === null) {
+      return Number(0)
+    }
     if (scale.decimals > 0) {
       if (scale.decimals === 1) {
         rounded = Number(